Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty string not to parse #1636

Open
wants to merge 2 commits into
base: release
Choose a base branch
from
Open

Conversation

lawff
Copy link

@lawff lawff commented May 30, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes # 空字符串是合法的输入, 但是解析的时候会解析成时间戳0的时候的时间, 这样就导致了, 明明是空的,但是显示的是有时间,比如说 8:00,目前只是简单的判断了下。 其余还有一段代码逻辑未看懂, 在 initDataFromDefaultValue 内部,判断是否是非法的时候是否有点问题,但未进行修改

Changelog

🇨🇳 Chinese

  • Fix: 修复 字符串为空时候,不要按时间戳0来解析

🇺🇸 English

  • Fix: fix empty string not to parse

Checklist

  • no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c48311:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@lawff lawff changed the base branch from main to release May 30, 2023 10:37
@pointhalo pointhalo requested a review from YannLynn June 5, 2023 03:28
@YannLynn
Copy link
Collaborator

YannLynn commented Jun 5, 2023

能举例(提供代码)描述一下你要解决的问题吗,从目前的修改和描述不太能get到你的修改行为和你的意图是否是匹配的

@lawff
Copy link
Author

lawff commented Jun 19, 2023

能举例(提供代码)描述一下你要解决的问题吗,从目前的修改和描述不太能get到你的修改行为和你的意图是否是匹配的

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants